-
Notifications
You must be signed in to change notification settings - Fork 642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE #4834] Add protocol exclusive fields filter for /v2/configuration
endpoint
#4835
Conversation
I don’t understand the purpose of your PR modification. Why do you want to filter out the fields of the parent class? The fields of the parent class should be some common fields, and the subclass is an extension. Why do you want to filter out the common fields? |
The EventMesh Dashboard needs to retrieve the configuration of each EventMesh Runtime after it is connected to the cluster, store it in the database for display on the frontend pages. Since
These issues could have been avoided, eliminating the display of redundant content, avoiding the need to maintain the Callers of the In the future, we may consider integrating the metaStorage Plugin with EventMesh Dashboard需要在接入集群后,获取每一台EventMesh Runtime的配置,存入数据库中,以供前端页面上展示。 由于
这些问题本可以被避免,不用显示重复内容,不需要在EventMesh Dashboard侧维护
在未来,我们可能会考虑将metaStorage Plugin与 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #4834
Motivation
Since
EventMeshTCPConfiguration
,EventMeshHTTPConfiguration
andEventMeshGrpcConfiguration
are subclasses ofCommonConfiguration
, their serialized JsonString would contain superclass fields, which enlarges the response body and brings in difficulty in gettingCommonConfiguration
fields.Modifications
EventMeshTCPConfiguration
,EventMeshHTTPConfiguration
andEventMeshGrpcConfiguration
, then addCommonConfiguration
into the response body.configs
param which accepts two values,exclusive
andall
.Documentation